Skip to content

WIP: Rename regression_test.py to use pytest #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

WIP: Rename regression_test.py to use pytest #562

wants to merge 6 commits into from

Conversation

@rjleveque
Copy link
Member

@rjleveque rjleveque commented Sep 1, 2023

See also clawpack/classic#90

Gives 4 errors currently, 3 of which are related to precision of results.

=========================== short test summary info ============================
FAILED test_storm.py::test_storm_IO - TypeError: 'DataArray' object cannot be interpreted as an integer
FAILED bowl_slosh/regression_test.py::BowlSloshTest::runTest - AssertionError: 
FAILED dtopo1/regression_test.py::DTopoTests::runTest - AssertionError: 
FAILED particles/regression_test.py::ParticlesTest::runTest - AssertionError: 
============ 4 failed, 26 passed, 2 skipped, 16 warnings in 41.24s =============

@mandli: maybe you can figure out what's wrong with test_storm.py and I'll look into the other failures. It seems like the results agree to about single precision but not to the specified tolerances.

@rjleveque
Rename regression_test.py to use pytest
674c670 
Gives 4 errors currently, 3 of which are related to precision of results.
@rjleveque
update tests/*/setrun.py to latest form for topofile specification, r…
9bb634b 
…emove max_level_deep
@rjleveque
simplify tests/dtopo1/regression_test.py and save gauge00002 data
0b41f48 
regression_data/gauge00001.txt also updated, very minor changes from previous
@rjleveque
update bowl_slosh/regression_data
201a35a
@rjleveque
update particles/regression_data
b6519f0
@rjleveque
Copy link
Member Author

rjleveque commented Sep 1, 2023

The disagreement with regression data is probably due to some changes in how regions are applied and hence what AMR grid patches are used. There are similarly small changes for a couple of amrclaw tests.

I updated the regression_data directories so that tests should all pass, except for test_storm.py

@rjleveque rjleveque mentioned this pull request Sep 1, 2023
Closed
@mandli
Copy link
Member

mandli commented Jun 4, 2025

Superseded by #642.

@mandli mandli closed this Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rjleveque @mandli